Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): enable mac tests on nightly and fix CI #16150

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

meeroslav
Copy link
Contributor

The #14347 had two side effects of introducing a dedicated e2e-macos target for mac-related projects:

  • CI always runs all mac e2e tests regardless whether they are affected or not
  • Nightly never runs any of them since the config is set to run only e2e target

This PR fixes that

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav requested a review from vsavkin as a code owner April 6, 2023 10:02
@meeroslav meeroslav self-assigned this Apr 6, 2023
@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 6, 2023 2:27pm

@nx-cloud
Copy link

nx-cloud bot commented Apr 6, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f92a853. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@meeroslav meeroslav merged commit e81bdd4 into nrwl:master Apr 6, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
@meeroslav meeroslav deleted the fix-ci-config branch April 27, 2023 09:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants